New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bessel-corrected std in ZScore transformation #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this has a pretty small effect for most of our cases. corrected=true
is the default --- do we know why we previously wrote corrected=false
?
Seems like just a mistake? |
mostly to force rerun ci
@adelinehillier, @glwagner tests fail because, I presume,
needs to change to |
@glwagner is this stale? |
We should probably put this change in, not sure why tests are failing though since this does very little. |
Probs the tests were run on an outdated version -- let's see now. |
22c54d5 fixed the tests |
merge at will @glwagner |
We might as well apply Bessel's correction since this is a sample standard deviation.