Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bessel-corrected std in ZScore transformation #292

Merged
merged 4 commits into from Jan 12, 2023
Merged

Conversation

adelinehillier
Copy link
Collaborator

We might as well apply Bessel's correction since this is a sample standard deviation.

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this has a pretty small effect for most of our cases. corrected=true is the default --- do we know why we previously wrote corrected=false?

@adelinehillier
Copy link
Collaborator Author

I guess this has a pretty small effect for most of our cases. corrected=true is the default --- do we know why we previously wrote corrected=false?

Seems like just a mistake?

mostly to force rerun ci
@navidcy
Copy link
Collaborator

navidcy commented Nov 6, 2022

@adelinehillier, @glwagner tests fail because, I presume,

μ, σ = mean(sliced_raw_observations), sqrt(cov(sliced_raw_observations; corrected=false))

needs to change to corrected = true. Am I right?

@navidcy
Copy link
Collaborator

navidcy commented Jan 10, 2023

@glwagner is this stale?

@glwagner
Copy link
Member

glwagner commented Jan 11, 2023

We should probably put this change in, not sure why tests are failing though since this does very little.

@navidcy
Copy link
Collaborator

navidcy commented Jan 11, 2023

Probs the tests were run on an outdated version -- let's see now.

@navidcy
Copy link
Collaborator

navidcy commented Jan 12, 2023

22c54d5 fixed the tests

@navidcy
Copy link
Collaborator

navidcy commented Jan 12, 2023

merge at will @glwagner

@glwagner glwagner merged commit 3f56069 into main Jan 12, 2023
@glwagner glwagner deleted the Bessel-corrected-std branch January 12, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants