Merge pull request #62634 from liuneng1994/std-except-parseDateTIme

Speed up `parseDateTime[InJodaSyntax]Or(Null|Zero)` on invalid inputs
ClickHouse · Apr 16, 2024 · 4e881be · 4e881be
2 parents 38d02d7 + b6af948
commit 4e881be
Show file tree

Hide file tree

Showing 8 changed files with 515 additions and 313 deletions.
diff --git a/.gitmodules b/.gitmodules
@@ -317,6 +317,9 @@
 [submodule "contrib/crc32-vpmsum"]
 	path = contrib/crc32-vpmsum
 	url = https://github.com/antonblanchard/crc32-vpmsum.git
+[submodule "contrib/expected"]
+	path = contrib/expected
+	url = https://github.com/TartanLlama/expected
 [submodule "contrib/liburing"]
 	path = contrib/liburing
 	url = https://github.com/axboe/liburing

diff --git a/contrib/CMakeLists.txt b/contrib/CMakeLists.txt
@@ -219,6 +219,8 @@ endif ()
 
 add_contrib (xxHash-cmake xxHash)
 
+add_contrib (expected-cmake expected)
+
 add_contrib (libbcrypt-cmake libbcrypt)
 
 add_contrib (google-benchmark-cmake google-benchmark)

diff --git a/contrib/expected b/contrib/expected
diff --git a/contrib/expected-cmake/CMakeLists.txt b/contrib/expected-cmake/CMakeLists.txt
@@ -0,0 +1,3 @@
+add_library(expected INTERFACE)
+target_include_directories(expected SYSTEM BEFORE INTERFACE "${ClickHouse_SOURCE_DIR}/contrib/expected/include")
+add_library(ch_contrib::expected ALIAS expected)
diff --git a/docker/test/fasttest/run.sh b/docker/test/fasttest/run.sh
@@ -150,6 +150,7 @@ function clone_submodules
             contrib/c-ares
             contrib/morton-nd
             contrib/xxHash
+            contrib/expected
             contrib/simdjson
             contrib/liburing
             contrib/libfiu

diff --git a/src/Functions/CMakeLists.txt b/src/Functions/CMakeLists.txt
@@ -46,6 +46,7 @@ list (APPEND PUBLIC_LIBS
 
 list (APPEND PRIVATE_LIBS
         ch_contrib::zlib
+        ch_contrib::expected
         boost::filesystem
         divide_impl
         ch_contrib::xxHash