Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up parseDateTime[InJodaSyntax]Or(Null|Zero) on invalid inputs #62634

Merged
merged 16 commits into from Apr 16, 2024

Conversation

liuneng1994
Copy link
Contributor

@liuneng1994 liuneng1994 commented Apr 15, 2024

This is a re-implementation of #62538 based on #62538 (comment)

parseDateTime previously always threw an exception when there was a parse error. This error was handled in the top-level loop and rethrown (for standard parseDateTime) or suppressed (*OrNull/*OrZero variants). With this PR, we no longer throw internal exceptions, instead faults are communicated back as error code.

In my local measurements, runtime to parse 100k invalid date/time strings (max_threads = 1) goes down from 2.1 sec to 0.0015 sec.

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Functions parseDateTimeOrNull, parseDateTimeOrZero, parseDateTimeInJodaSyntaxOrNull and parseDateTimeInJodaSyntaxOrZero now run significantly faster (10x - 1000x) when the input contains mostly non-parseable values.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@liuneng1994

This comment was marked as outdated.

@rschu1ze
Copy link
Member

Thanks, I'll check, but please expect a bit of delay as I am working in the next 1.5 weeks from a remote location with only random access to my laptop.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-performance Pull request with some performance improvements submodule changed At least one submodule changed in this PR. labels Apr 15, 2024
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Apr 15, 2024

This is an automated comment for commit b6af948 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@rschu1ze rschu1ze self-assigned this Apr 15, 2024
@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label Apr 15, 2024
@rschu1ze

This comment was marked as outdated.

@liuneng1994

This comment was marked as outdated.

@clickhouse-ci clickhouse-ci bot added the manual approve Manual approve required to run CI label Apr 15, 2024
@rschu1ze rschu1ze changed the title Speed up parseDateTime[InJodaSyntax]Or(Null|Zero) on invalid inputs Speed up parseDateTime[InJodaSyntax]Or(Null|Zero) on invalid inputs Apr 15, 2024
@rschu1ze
Copy link
Member

@liuneng1994 Thanks a lot. I fixed a few things:

  • I added [[nodiscard]] everywhere because it is easy to forget checking the return code. There was actually one place where a return code was not checked.
  • I reduced the number of thread in the performance tests (back) from 10 to 1. It is not guaranteed that every machine in CI has 10 cores. Also, performance improvements (because we no longer unwind the stack due to exception handling once per row), will also be visible for single-thead execution.

@rschu1ze
Copy link
Member

When the new use case is run in a single thread, a timeout will occur. Is there any way to increase the timeout of this use case? Otherwise, the number of test records needs to be reduced.

The only way to deal with that is to reduce the dataset size... I also did that (1 mio rows --> 100k rows).

@rschu1ze rschu1ze added this pull request to the merge queue Apr 16, 2024
Merged via the queue into ClickHouse:master with commit 4e881be Apr 16, 2024
233 of 243 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors manual approve Manual approve required to run CI pr-performance Pull request with some performance improvements pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants