Merge pull request #60160 from rschu1ze/bool-cast

Allow casting of bools in string representation to to true bools

src/Interpreters/convertFieldToType.cpp

@@ -493,10 +493,12 @@ Field convertFieldToTypeImpl(const Field & src, const IDataType & type, const ID
     {
         /// Promote data type to avoid overflows. Note that overflows in the largest data type are still possible.
         /// But don't promote Float32, since we want to keep the exact same value
+        /// Also don't promote domain types (like bool) because we would otherwise use the serializer of the promoted type (e.g. UInt64 for
+        /// bool, which does not allow 'true' and 'false' as input values)
         const IDataType * type_to_parse = &type;
         DataTypePtr holder;
 
-        if (type.canBePromoted() && !which_type.isFloat32())
+        if (type.canBePromoted() && !which_type.isFloat32() && !type.getCustomSerialization())
         {
             holder = type.promoteNumericType();
             type_to_parse = holder.get();

tests/queries/0_stateless/02933_compare_with_bool_as_string.reference

@@ -0,0 +1 @@
+1

tests/queries/0_stateless/02933_compare_with_bool_as_string.sql

@@ -0,0 +1 @@
+select true = 'true';