New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow casting of bools in string representation to to true bools #60160
Conversation
@@ -0,0 +1 @@ | |||
select true = 'true'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has twice as many test lines as changed code lines.
This is an automated comment for commit df53826 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Are we in JavaScript? Do we need to introduce somewhat like P.S. I checked and the result of
|
Didn't know about JS's This PR only affects domain data types (e.g. EDIT: In case of doubt, trust PostgreSQL. The question is: to what does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #57256
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Boolean values in string representation now cast to true bools. E.g. this query previously threw an exception but now works:
SELECT true = 'true'
.