Merge pull request #29454 from Avogar/fix-least-greatest

Fix logical error in functions greatest/least
ClickHouse · Sep 28, 2021 · cd1e72e · cd1e72e
2 parents 8eaff1a + cc40e36
commit cd1e72e
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 0 deletions.
diff --git a/src/Functions/LeastGreatestGeneric.h b/src/Functions/LeastGreatestGeneric.h
@@ -107,6 +107,8 @@ class LeastGreatestOverloadResolver : public IFunctionOverloadResolver
     FunctionBasePtr buildImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr & return_type) const override
     {
         DataTypes argument_types;
+        for (const auto & argument : arguments)
+            argument_types.push_back(argument.type);
 
         /// More efficient specialization for two numeric arguments.
         if (arguments.size() == 2 && isNumber(arguments[0].type) && isNumber(arguments[1].type))

diff --git a/tests/queries/0_stateless/01822_short_circuit.sql b/tests/queries/0_stateless/01822_short_circuit.sql
@@ -153,3 +153,4 @@ select number % 2 and toLowCardinality(number) from numbers(5);
 select number % 2 or toLowCardinality(number) from numbers(5);
 select if(toLowCardinality(number) % 2, number, number + 1) from numbers(10);
 select multiIf(toLowCardinality(number) % 2, number, number + 1) from numbers(10);
+
diff --git a/tests/queries/0_stateless/02032_short_circuit_least_greatest_bug.reference b/tests/queries/0_stateless/02032_short_circuit_least_greatest_bug.reference
@@ -0,0 +1,20 @@
+0
+1
+1
+1
+1
+1
+0
+1
+1
+1
+0
+1
+0
+0
+0
+1
+0
+1
+0
+0
diff --git a/tests/queries/0_stateless/02032_short_circuit_least_greatest_bug.sql b/tests/queries/0_stateless/02032_short_circuit_least_greatest_bug.sql
@@ -0,0 +1,2 @@
+select 1 and greatest(number % 2, number % 3) from numbers(10);
+select 1 and least(number % 2, number % 3) from numbers(10);