Avoid superfluous dictionaries load #10164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blinkov
added
the
pr-not-for-changelog
alexey-milovidov
added
pr-improvement
|
This is not non-significant. |
blinkov
added
the
pr-not-for-changelog
alexey-milovidov
approved these changes
Apr 9, 2020
azat
force-pushed
the
system.tables-superfluous-dict-reload
branch
from
5aa3f81
to
79cfcb5
Compare
azat
force-pushed
the
system.tables-superfluous-dict-reload
branch
from
79cfcb5
to
20e997e
Compare
vitlibar
reviewed
Apr 10, 2020
azat
force-pushed
the
system.tables-superfluous-dict-reload
branch
from
20e997e
to
5b1f40d
Compare
This patch avoids loading dictionaries for: - SELECT * FROM system.tables (used by clickhouse-client for completion) - SHOW CREATE TABLE some_dict But the dictionary will still be loaded on: - SHOW CREATE TABLE some_dict (from the database with Dictionary engine)
azat
force-pushed
the
system.tables-superfluous-dict-reload
branch
from
7619121
to
55a143d
Compare
alexey-milovidov
removed
the
pr-not-for-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid superfluous dictionaries load (system.tables, DROP/SHOW CREATE TABLE)
Detailed description / Documentation draft:
This patch avoids loading dictionaries for:
funny looks like the dictionary will be loaded before DROP
Refs: #7916