Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copier test #11573

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Conversation

nikitamikhaylov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added a random sampling of instances where copier is executed. It is needed to avoid Too many simultaneous queries error. Also increased timeout and decreased fault probability.

@nikitamikhaylov nikitamikhaylov added the testing Special issue with list of bugs found by CI label Jun 10, 2020
@blinkov blinkov added the pr-build Pull request with build/testing/packaging improvement label Jun 10, 2020
@alexey-milovidov alexey-milovidov self-assigned this Jun 10, 2020
def test_copy_month_to_week_partition(started_cluster):
execute_task(Task2(started_cluster), [])

@pytest.mark.timeout(600)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test really require 10 minutes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but it is stochastic test and we have a little positive probability of a sequence of failures.

@nikitamikhaylov nikitamikhaylov merged commit 4bf46ed into ClickHouse:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-docs-needed pr-build Pull request with build/testing/packaging improvement testing Special issue with list of bugs found by CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants