Fix typos in code #12003
Merged
Fix typos in code #12003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -112,6 +112,10 @@ void registerDataTypeDomainIPv4AndIPv6(DataTypeFactory & factory) | |||
| return std::make_pair(DataTypeFactory::instance().get("FixedString(16)"), | |||
| std::make_unique<DataTypeCustomDesc>(std::make_unique<DataTypeCustomFixedName>("IPv6"), std::make_unique<DataTypeCustomIPv6Serialization>())); | |||
| }); | |||
|
|
|||
| /// MySQL, MariaDB | |||
There was a problem hiding this comment.
This is a bonus.
Broken in #11903 |
|
@akuzm Any ideas on how to automate this? |
Not sure. The problem is that we don't want to support custom dictionaries? Maybe we can pipe all sources to clickhouse-local, build a list of words that are used in sources, and warn if we add a word that is not in the list, but is trigram-similar to an existing word, and detect typos in this way. |
|
Yes, I had the same idea. We can support custom dictionary and store it directly in repository. But it will be very fragile if we don't normalize words. We can invest into text processing functions in ClickHouse but it's a big project. |
There are false matches (but not too much), and be adjusted by flags / dicts. Check: https://github.com/codespell-project/codespell |
|
There is also But it requires tuning (it stores & filling dictionaries incrementally etc. - smth like you describe above) check |
|
This result looks very promising, we can incorporate this tool with a simple exception list. |
|
It also has plenty of options / switches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix some typos in code.
Detailed description / Documentation draft:
It's easy: