Test for input_format_allow_errors_num in CSV #12105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w_errors_num in CSV
blinkov
added
the
pr-not-for-changelog
filimonov
added
altinity
and removed
pr-not-for-changelog
blinkov
added
the
pr-not-for-changelog
filimonov
commented
Jul 3, 2020
| echo "Return code: $?" | ||
| cat "$STD_ERROR_CAPTURED" | ||
|
|
||
| rm "$STD_ERROR_CAPTURED" "$SAMPLE_FILE" |
There was a problem hiding this comment.
new line missing, i can add, but don't want to rerun CI one more time for that. So may be just after/before merge
tavplubix
reviewed
Jul 3, 2020
| 1 0 | ||
| 2 0 | ||
| 3 0 | ||
| 4 0 |
There was a problem hiding this comment.
FYI ill-formatted rows should be skipped, but it does not happen in this case because of another issue
tavplubix
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV
Detailed description / Documentation draft:
Closes #10668
The issue itself was fixed earlier, most probably by #10418