-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix access to redis dictionary after connection was dropped once #13082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jul 29, 2020
alexey-milovidov
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but why "don't test"?
How we supposed to merge it without even build check?
I wanted to add a test for this case, but stuck in the integration tests framework. Maybe it's ok to merge without test. |
Timeouts for stress tests were increased, need to try again. |
This was referenced Aug 10, 2020
Merged
Merged
Merged
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 10, 2020
…ion was dropped once
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 10, 2020
…ion was dropped once
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 10, 2020
…ion was dropped once
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 10, 2020
…ion was dropped once
CurtizJ
added a commit
that referenced
this pull request
Aug 14, 2020
Backport #13082 to 20.5: Fix access to redis dictionary after connection was dropped once
CurtizJ
added a commit
that referenced
this pull request
Aug 14, 2020
Backport #13082 to 20.6: Fix access to redis dictionary after connection was dropped once
CurtizJ
added a commit
that referenced
this pull request
Aug 14, 2020
Backport #13082 to 20.7: Fix access to redis dictionary after connection was dropped once
CurtizJ
added a commit
that referenced
this pull request
Aug 14, 2020
Backport #13082 to 20.4: Fix access to redis dictionary after connection was dropped once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix access to redis dictionary after connection was dropped once. It may happen with
cache
anddirect
dictionary layouts.