Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to redis dictionary after connection was dropped once #13082

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Jul 29, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix access to redis dictionary after connection was dropped once. It may happen with cache and direct dictionary layouts.

@CurtizJ CurtizJ added the do not test disable testing on pull request label Jul 29, 2020
@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Jul 29, 2020
Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but why "don't test"?
How we supposed to merge it without even build check?

@alexey-milovidov alexey-milovidov self-assigned this Jul 30, 2020
@CurtizJ
Copy link
Member Author

CurtizJ commented Jul 30, 2020

I wanted to add a test for this case, but stuck in the integration tests framework. Maybe it's ok to merge without test.

@CurtizJ CurtizJ removed the do not test disable testing on pull request label Jul 30, 2020
@alexey-milovidov
Copy link
Member

Timeouts for stress tests were increased, need to try again.

@alexey-milovidov alexey-milovidov merged commit 8912a1c into ClickHouse:master Aug 10, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 10, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 10, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 10, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 10, 2020
CurtizJ added a commit that referenced this pull request Aug 14, 2020
Backport #13082 to 20.5: Fix access to redis dictionary after connection was dropped once
CurtizJ added a commit that referenced this pull request Aug 14, 2020
Backport #13082 to 20.6: Fix access to redis dictionary after connection was dropped once
CurtizJ added a commit that referenced this pull request Aug 14, 2020
Backport #13082 to 20.7: Fix access to redis dictionary after connection was dropped once
CurtizJ added a commit that referenced this pull request Aug 14, 2020
Backport #13082 to 20.4: Fix access to redis dictionary after connection was dropped once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants