-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in "extractAllGroups" function #14889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Sep 16, 2020
AST Fuzzer:
But no errors in the server log and in the fuzzer log. |
alesapin
approved these changes
Sep 17, 2020
No errors would be bad, better investigate. But I found the error in server log:
It also looks very bad... |
But why would we be out of memory mappings on a server that is basically idle? Looks like a memory leak. |
This was referenced Sep 17, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 17, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Sep 17, 2020
Backport #14889 to 20.7: Fix error in "extractAllGroups" function
alexey-milovidov
added a commit
that referenced
this pull request
Sep 17, 2020
Backport #14889 to 20.8: Fix error in "extractAllGroups" function
alexey-milovidov
added a commit
that referenced
this pull request
Sep 17, 2020
Backport #14889 to 20.9: Fix error in "extractAllGroups" function
alexey-milovidov
added a commit
that referenced
this pull request
Sep 17, 2020
Backport #14889 to 20.6: Fix error in "extractAllGroups" function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the issue when some invocations of
extractAllGroups
function may trigger "Memory limit exceeded" error. This fixes #13383