Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random timezone in stateless and stateful tests #15408

Merged
merged 67 commits into from
Jul 27, 2021

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Sep 28, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now we ran stateful and stateless tests in random timezones. Fixes #12439. Reading String as DateTime and writing DateTime as String in Protobuf format now respect timezone. Reading UInt16 as DateTime in Arrow and Parquet formats now treat it as Date and then converts to DateTime with respect to DateTime's timezone, because Date is serialized in Arrow and Parquet as UInt16. GraphiteMergeTree now respect time zone for rounding of times. Fixes #5098. Author: @alexey-milovidov.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Sep 28, 2020
@alesapin alesapin added the force tests The label does nothing, NOOP, None, nil label Sep 28, 2020
@alexey-milovidov alexey-milovidov self-assigned this Sep 28, 2020
@qoega
Copy link
Member

qoega commented Sep 30, 2020

Now we have to fix them :)

@alexey-milovidov alexey-milovidov added the st-waiting-for-fix We are waiting for fixes in this issue or pull request label Oct 13, 2020
@alesapin alesapin removed the force tests The label does nothing, NOOP, None, nil label Nov 24, 2020
@alexey-milovidov alexey-milovidov added the force tests The label does nothing, NOOP, None, nil label Jan 6, 2021
@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-build Pull request with build/testing/packaging improvement labels Jul 24, 2021
@alexey-milovidov
Copy link
Member

Finally #5098 is needed.

@alexey-milovidov
Copy link
Member

Stress test: #24194 (comment)

@alexey-milovidov
Copy link
Member

01098_msgpack_format

Another exception from parallel runs.

@alexey-milovidov alexey-milovidov merged commit d7b2404 into master Jul 27, 2021
@alexey-milovidov alexey-milovidov deleted the random_timezone_for_stateless_tests branch July 27, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force tests The label does nothing, NOOP, None, nil pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests in CI with random time zone. GraphiteMergeTree: use time zone of the data type for rounding.
4 participants