Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include dynamic columns for wildcard query #17462

Merged
merged 4 commits into from
Jan 10, 2021
Merged

include dynamic columns for wildcard query #17462

merged 4 commits into from
Jan 10, 2021

Conversation

chenziliang
Copy link
Contributor

@chenziliang chenziliang commented Nov 27, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Return dynamic columns like MATERIALIZED / ALIAS for wildcard query when switches asterisk_include_materialized_columns and asterisk_include_alias_columns are turned on.

Detailed description / Documentation draft:
Previously for wildcard query like SELECT * FROM <table>, ALIAS/MATERIALIZED dynamic columns will not be included.
Adding switches asterisk_include_materialized_columns and asterisk_include_alias_columns to include these dynamic columns for wildcard query respectively. By default, these 2 switches are false for backward compatibility.

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels Nov 27, 2020
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Nov 27, 2020

What do you think about separating it to several settings:
asterisk_include_materialized_columns
asterisk_include_alias_columns
for more fine grained and explicit control?

@alexey-milovidov alexey-milovidov self-assigned this Nov 27, 2020
@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Nov 27, 2020
…alized_columns switches to include materialized columns and alias columns respectively for wildcard query
@chenziliang chenziliang changed the title wildcard dynamic columns include dynamic columns for wildcard query Nov 28, 2020
@chenziliang
Copy link
Contributor Author

What do you think about separating it to several settings:
asterisk_include_materialized_columns
asterisk_include_alias_columns
for more fine grained and explicit control?

Make total sense and revised the patch accordingly. Thanks Alexey.

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-milovidov alexey-milovidov merged commit 6d0799b into ClickHouse:master Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants