-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TSan report in StorageSet and StorageJoin #18385
Conversation
@@ -127,8 +126,6 @@ class Set | |||
|
|||
/** Protects work with the set in the functions `insertFromBlock` and `execute`. | |||
* These functions can be called simultaneously from different threads only when using StorageSet, | |||
* and StorageSet calls only these two functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not hold after #16306, hence the bug.
Performance:
|
I see that performance package should contain it (and no errors from |
|
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible race condition in concurrent usage of
Set
orJoin
tables and selects fromsystem.tables
.Detailed description / Documentation draft:
See https://clickhouse-test-reports.s3.yandex.net/9516/6e52fb1f5d1f751023346c80e12a357abae23be7/stress_test_(thread)/stderr.log
Found in #9516. The issue first appeared in #16306 (version 20.11).