Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TSan report in StorageSet and StorageJoin #18385

Merged
merged 4 commits into from
Dec 30, 2020

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible race condition in concurrent usage of Set or Join tables and selects from system.tables.

Detailed description / Documentation draft:
See https://clickhouse-test-reports.s3.yandex.net/9516/6e52fb1f5d1f751023346c80e12a357abae23be7/stress_test_(thread)/stderr.log
Found in #9516. The issue first appeared in #16306 (version 20.11).

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 23, 2020
@@ -127,8 +126,6 @@ class Set

/** Protects work with the set in the functions `insertFromBlock` and `execute`.
* These functions can be called simultaneously from different threads only when using StorageSet,
* and StorageSet calls only these two functions.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not hold after #16306, hence the bug.

@alexey-milovidov alexey-milovidov marked this pull request as ready for review December 29, 2020 18:22
@alexey-milovidov
Copy link
Member Author

Performance:

2020.12.30 18:35:19.034788 [ 93 ] {} TLDListsHolder: public_suffix_list loading from /top_level_domains/public_suffix_list.dat
2020.12.30 18:35:19.035085 [ 93 ] {} Application: DB::ErrnoException: Cannot open file /top_level_domains/public_suffix_list.dat, errno: 2, strerror: No such file or directory
2020.12.30 18:35:19.035089 [ 93 ] {} Application: shutting down

@azat
Copy link
Collaborator

azat commented Dec 30, 2020

2020.12.30 18:35:19.035085 [ 93 ] {} Application: DB::ErrnoException: Cannot open file /top_level_domains/public_suffix_list.dat, errno: 2, strerror: No such file or directory

I see that performance package should contain it (and no errors from cp), however I don't see it in the performance.tgz archive.

@azat
Copy link
Collaborator

azat commented Jan 2, 2021

I see that performance package should contain it (and no errors from cp), however I don't see it in the performance.tgz archive.

#18686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants