Fix mistake in greatCircleAngle #19789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
hombit
reviewed
Jan 29, 2021
| @@ -95,7 +95,7 @@ void geodistInit() | |||
|
|
|||
| sphere_metric_meters_lut[i] = static_cast<float>(sqr((EARTH_DIAMETER * PI / 360) * cos(latitude))); | |||
|
|
|||
| sphere_metric_lut[i] = cosf(latitude); | |||
| sphere_metric_lut[i] = sqr(cosf(latitude)); | |||
|
Thank you, looks good for me! |
This was referenced Jan 29, 2021
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
…7d6d7985224700ad6876b675d7c7c9 Cherry pick #19789 to 20.12: Fix mistake in greatCircleAngle
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
…7d6d7985224700ad6876b675d7c7c9 Cherry pick #19789 to 20.11: Fix mistake in greatCircleAngle
vitlibar
pushed a commit
that referenced
this pull request
Feb 1, 2021
…d6d7985224700ad6876b675d7c7c9 Cherry pick #19789 to 21.1: Fix mistake in greatCircleAngle
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 17, 2021
This was referenced Feb 17, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Feb 17, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Feb 19, 2021
Backport #19789 to 21.1: Fix mistake in greatCircleAngle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The function
greatCircleAnglereturned inaccurate results in previous versions. This closes #19769.