Cache dictionaries lru cache #20595
Cache dictionaries lru cache #20595
Conversation
robot-clickhouse
added
doc-alert
pr-feature
kitaisreal
force-pushed
the
cache-dictionaries-lru-cache
branch
2 times, most recently
from
f49d8a2
to
afbcbae
Compare
kitaisreal
force-pushed
the
cache-dictionaries-lru-cache
branch
4 times, most recently
from
aa56276
to
24070a3
Compare
robot-clickhouse
added
the
submodule changed
kitaisreal
force-pushed
the
cache-dictionaries-lru-cache
branch
2 times, most recently
from
449fecc
to
712e9f2
Compare
| const char * ColumnString::skipSerializedInArena(const char * pos) const | ||
| { | ||
| const size_t string_size = unalignedLoad<size_t>(pos); | ||
| pos += sizeof(string_size); |
There was a problem hiding this comment.
There is no difference.
| @@ -195,6 +202,8 @@ inline size_t DefaultHash64(std::enable_if_t<(sizeof(T) > sizeof(UInt64)), T> ke | |||
| static_cast<UInt64>(key >> 128) ^ | |||
| static_cast<UInt64>(key >> 256)); | |||
| } | |||
|
|
|||
| assert(false); | |||
There was a problem hiding this comment.
throw Exception("Wrong specialization for type ...", ErrorCodes::..);
There was a problem hiding this comment.
No exception is necessary here, we can't get here.
There was a problem hiding this comment.
But it is better for future readers. At least a comment required here
| @@ -341,6 +350,11 @@ struct IntHash32 | |||
| } | |||
| else if constexpr (sizeof(T) <= sizeof(UInt64)) | |||
| return intHash32<salt>(key); | |||
|
|
|||
| assert(false); | |||
There was a problem hiding this comment.
throw Exception("Wrong specialization for type ...", ErrorCodes::..);
There was a problem hiding this comment.
No exception is necessary here, we can't get here.
There was a problem hiding this comment.
But it is better for future readers. At least a comment required here
| } | ||
| catch (...) | ||
| { | ||
| /// TODO: Write log |
There was a problem hiding this comment.
Dangerous, it will may lead to std::terminate, because we have ThreadPool
There was a problem hiding this comment.
@nikitamikhaylov it was your comment.
| } | ||
| catch (...) | ||
| { | ||
| std::unique_lock<std::mutex> lock(update_mutex); |
| using KeyType = std::conditional_t<dictionary_key_type == DictionaryKeyType::simple, UInt64, StringRef>; | ||
|
|
||
| /// Constructor for complex keys update request | ||
| explicit CacheDictionaryUpdateUnit( |
There was a problem hiding this comment.
There is no case when client will want to construct CacheDictionaryUpdateUnit without specifying it type.
|
|
||
| auto type_call = [&](const auto &dictionary_attribute_type) | ||
| /// TODO: Move this to DictionaryStructure | ||
| for (const auto & attribute : dict_struct.attributes) |
There was a problem hiding this comment.
Comment is for next refactoring pull requests related to hierarchy handling.
kitaisreal
force-pushed
the
cache-dictionaries-lru-cache
branch
from
7e0c0b2
to
4db7131
Compare
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Fixes #20252.
Fixes #20194.
Fixes #10863.
Fixes #19714.
Fixes #21517.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added async update in
ComplexKeyCache,SSDCache,SSDComplexKeyCachedictionaries.Added support for Nullable type in
Cache,ComplexKeyCache,SSDCache,SSDComplexKeyCachedictionaries.Added support for multiple attributes fetch with
dictGet,dictGetOrDefaultfunctions. Fixes #21517.