-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add uniqThetaSketch #22609
add uniqThetaSketch #22609
Conversation
…o datasketches-uniq
…o datasketches-uniq
…o datasketches-uniq
The failure of build seems to be caused by DataSketches submodule is not checked out. |
We should add the needed submodule in this list: ClickHouse/docker/test/fasttest/run.sh Line 160 in 30f2d83
I will do it. |
You also should support case when ENABLE_DATASKETCHES=0 in code. Now it just cannot build with it. Put all logic with submodule under |
Comments addressed. PTAL, thanks~ @Avogar |
LGTM, some problems with synchronization again, I will fix it and will merge. |
I put all tests with uniqThetaSketch in one file to have an ability to disable it when we cannot use datasketches submodule. Lets wait for the tests and if there are no errors - merge. |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Detailed description / Documentation draft: