Fix abnormal termination when hdfs is unreachable #24191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
alesapin
approved these changes
May 17, 2021
| @@ -26,6 +26,8 @@ class WriteBufferFromHDFS : public BufferWithOwnMemory<WriteBuffer> | |||
| ~WriteBufferFromHDFS() override; | |||
|
|
|||
| void sync() override; | |||
|
|
|||
| void finalize() override; | |||
There was a problem hiding this comment.
It's not super-clear that this the fix is the override keyword :)
|
|
This was referenced May 18, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 18, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 18, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
May 18, 2021
alesapin
added a commit
that referenced
this pull request
May 19, 2021
Backport #24191 to 21.3: Fix abnormal termination when hdfs is unreachable
alesapin
added a commit
that referenced
this pull request
May 19, 2021
Backport #24191 to 21.4: Fix abnormal termination when hdfs is unreachable
alesapin
added a commit
that referenced
this pull request
May 19, 2021
Backport #24191 to 21.5: Fix abnormal termination when hdfs is unreachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix abnormal server termination due to hdfs becoming not accessible during query execution. Closes #24117.
Detailed description / Documentation draft:
In #24117 hdfs entered safemode due to unreachable namenodes and the query crashed the server - can be reproduced by starting a long query and while it is not yet finished executing inside hdfs the command:
hdfs dfsadmin -safemode enter. (stacktrace).