-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert history file from readline format to replxx format #25888
Merged
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
azat:replxx-convert-history-file
Jul 2, 2021
Merged
Convert history file from readline format to replxx format #25888
alexey-milovidov
merged 3 commits into
ClickHouse:master
from
azat:replxx-convert-history-file
Jul 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
Pull request with some product improvements
label
Jun 30, 2021
azat
force-pushed
the
replxx-convert-history-file
branch
from
June 30, 2021 19:05
efd440f
to
3d32463
Compare
replxx requires each history line to prepended with time line: ### YYYY-MM-DD HH:MM:SS.SSS select 1 And w/o those service lines it will load all lines from history file as one history line for suggestion. And if there are lots of lines in file it will take lots of time (getline() + tons of reallocations).
azat
force-pushed
the
replxx-convert-history-file
branch
from
June 30, 2021 19:06
3d32463
to
626f47e
Compare
alexey-milovidov
approved these changes
Jul 2, 2021
Thank you! LGTM. The code is dirty but we don't need anything good here. |
Sorry, this PR contains a bug. Fresh installation:
I will revert. |
alexey-milovidov
added
the
bug
Confirmed user-visible misbehaviour in official release
label
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Convert history file from readline format to replxx format
Detailed description / Documentation draft:
replxx requires each history line to prepended with time line:
And w/o those service lines it will load all lines from history file as
one history line for suggestion. And if there are lots of lines in file it
will take lots of time (getline() + tons of reallocations).
Cc: @den-crane
Cc: @filimonov