Fix crash on call dictGet() with bad arguments. #25913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
vitlibar
force-pushed
the
fix-crash-on-dictget-with-bad-argument
branch
2 times, most recently
from
318ef7b
to
3e72dcf
Compare
vitlibar
commented
Jul 2, 2021
| auto opt_name = tryGetIdentifierName(ast); | ||
| if (opt_name && !data.aliases.count(*opt_name) && ast->as<ASTIdentifier>()) | ||
| { | ||
| ptr->as<ASTFunction>()->arguments->children[0] = ast->as<ASTIdentifier>()->createTable(); |
There was a problem hiding this comment.
The crash was because of this line: the function createTable() returned nullptr, assert() didn't alert on that in release, and then InDepthNodeVisitor::visitChildren() tried to iterate through a null child.
vitlibar
force-pushed
the
fix-crash-on-dictget-with-bad-argument
branch
from
3e72dcf
to
8b4fabe
Compare
alexey-milovidov
approved these changes
Jul 2, 2021
This was referenced Jul 3, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 3, 2021
alexey-milovidov
added a commit
that referenced
this pull request
Jul 3, 2021
Backport #25913 to 21.7: Fix crash on call dictGet() with bad arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
Fix crash on call dictGet() with bad arguments.
This PR fixes #25533