Use bytes instead of strings in the GRPC protocol. #27431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
vitlibar
commented
Aug 8, 2021
| @@ -32,7 +32,7 @@ message ExternalTable { | |||
| // Data to insert to the external table. | |||
| // If a method with streaming input (i.e. ExecuteQueryWithStreamInput() or ExecuteQueryWithStreamIO()) is used, | |||
| // then data for insertion to the same external table can be split between multiple QueryInfos. | |||
| string data = 3; | |||
| bytes data = 3; | |||
There was a problem hiding this comment.
The types bytes and string are translated by protobuf compiler to the same C++ type std::string, however they're translated to different types in some other languages (Java, Go, Python). The type bytes here is more appropriate because data contains a sequence of bytes, not characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
Use bytes instead of strings for binary data in the GRPC protocol.