Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projection bug fixes and refactoring. #28178

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

amosbird
Copy link
Collaborator

@amosbird amosbird commented Aug 26, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Multiple small fixes for projections. See detailed description in pr.

Detailed description / Documentation draft:

  1. disable projection when sampling is in use.
  2. proper handling empty_result_for_aggregation_by_empty_set for projections.
  3. fix incomplete implementation of in-memory part projection.
  4. load temporary tables before system tables so that projections can work in system tables.
  5. enhance projection query analysis to match more queries, such as virtual columns and group by with empty keys.
  6. fix projection desc lost in CTAS clause.
  7. add projections Array(String) to system.parts.
  8. add more comments and refactor/remove duplicate code.

It's the base PR of #26286 and it addresses several review sugguestions there.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 26, 2021
@KochetovNicolai KochetovNicolai self-assigned this Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants