Improve MsgPack input/output format #29077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2021 14:25
robot-clickhouse
added
the
pr-improvement
|
Will add more tests and will update docs |
kssenii
approved these changes
Sep 21, 2021
|
@Mergifyio update |
|
Command
|
|
@Mergifyio update |
|
Command
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible LogicalError, support more types in MsgPack input/output format.
Detailed description / Documentation draft:
Fix possible LogicalError while inserting data with wrong type in MsgPack format by adding more type checks, support MsgPack types
bool,binandmap, allow to insert data into Nullable columns, allow to insert/output data in/from LowCardinality columns.