Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove function bayesAB #29934

Merged
merged 3 commits into from Oct 12, 2021
Merged

Remove function bayesAB #29934

merged 3 commits into from Oct 12, 2021

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Function bayesAB is removed. This closes #26233.

@robot-clickhouse robot-clickhouse added the pr-backward-incompatible Pull request with backwards incompatible changes label Oct 10, 2021
@alexey-milovidov
Copy link
Member Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2021

Command update: success

Branch has been successfully updated

@nikitamikhaylov nikitamikhaylov self-assigned this Oct 11, 2021
@nikitamikhaylov nikitamikhaylov merged commit 7c67d76 into master Oct 12, 2021
@gyuton
Copy link
Contributor

gyuton commented Oct 12, 2021

@nikitamikhaylov Should we remove the docs?

@alexey-milovidov
Copy link
Member Author

Yes.

@alexey-milovidov
Copy link
Member Author

@nikitamikhaylov I've left the two submodules in place, maybe this function can be reborn?

@nikitamikhaylov
Copy link
Member

@nikitamikhaylov I've left the two submodules in place, maybe this function can be reborn?

@alexey-milovidov I don't know, I know nothing about Bayes math in A/B testing. It could be impractical, etc... I have to learn more in this area.

@alexey-milovidov
Copy link
Member Author

That's good - we will have a chance to understand and describe it properly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backward-incompatible Pull request with backwards incompatible changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove function bayesAB or break it in backward incompatible way.
4 participants