-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column #30189
Merged
kssenii
merged 1 commit into
ClickHouse:master
from
azat:fix-INSERT-SELECT-MATERIALIZED
Oct 15, 2021
Merged
Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column #30189
kssenii
merged 1 commit into
ClickHouse:master
from
azat:fix-INSERT-SELECT-MATERIALIZED
Oct 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Oct 14, 2021
I wish this PR has |
…able column Required columns of the default expression should not be converted to NULL, since this map value to default and MATERIALIZED values will not work. Consider the following structure: - A Nullable(Int64) - X Int64 materialized coalesce(A, -1) With recursive_null_as_default=true you will get: _CAST(coalesce(A, -1), 'Int64') AS X, NULL AS A And this will ignore default expression. Fixes: ClickHouse#23524 (Cc: @kssenii) Fixes: ClickHouse#29729 (Cc: @tavplubix) Backport: 21.7+
azat
force-pushed
the
fix-INSERT-SELECT-MATERIALIZED
branch
from
October 14, 2021 22:36
2f5134c
to
a063097
Compare
|
kssenii
approved these changes
Oct 15, 2021
This was referenced Oct 15, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 15, 2021
…LIZED column based of Nullable column
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 15, 2021
…IZED column based of Nullable column
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 15, 2021
…IZED column based of Nullable column
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 15, 2021
…IZED column based of Nullable column
alexey-milovidov
added a commit
that referenced
this pull request
Oct 16, 2021
Backport #30189 to 21.10: Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
kssenii
added a commit
that referenced
this pull request
Oct 20, 2021
Backport #30189 to 21.8: Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
kssenii
added a commit
that referenced
this pull request
Oct 20, 2021
Backport #30189 to 21.9: Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix INSERT SELECT incorrectly fills MATERIALIZED column based of Nullable column
Detailed description / Documentation draft:
Required columns of the default expression should not be converted to NULL,
since this map value to default and MATERIALIZED values will not work.
Consider the following structure:
With recursive_null_as_default=true you will get:
And this will ignore default expression.
Fixes: #23524 (Cc: @kssenii)
Fixes: #29729 (Cc: @tavplubix)
Backport: 21.7+