Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that LowCardinality of Int256 cannot be created. #31832

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Nov 25, 2021

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix the issue that LowCardinality of Int256 cannot be created.

Found by fuzzer.

While fixing this issue I discovered indecent code around TypeList:

  • it was using abbreviations like TLUtils and I deeply hate abbreviations;
  • TLIntegral confusingly consisted not only integer types, but also floating point types; and it did not consist all integer types.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Nov 25, 2021
@kitaisreal kitaisreal self-assigned this Nov 25, 2021
@alexey-milovidov alexey-milovidov merged commit d929239 into master Nov 26, 2021
@alexey-milovidov alexey-milovidov deleted the strange-code-typelist branch November 26, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants