adding # as a recognized start of single line comment #34230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
|
|
alexey-milovidov
added
the
can be tested
| @@ -280,6 +280,18 @@ Token Lexer::nextTokenImpl() | |||
| } | |||
| return Token(TokenType::Slash, token_begin, pos); | |||
| } | |||
| case '#': /// start of single line comment, MySQL style | |||
There was a problem hiding this comment.
Awesome,
We need a test.
KochetovNicolai
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry:
Added
#!and#as a recognised start of a single line comment.Reference to task #34138