Fix reading from type object #35687
Merged
Fix reading from type object #35687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtizJ
commented
Mar 29, 2022
Comment on lines
-96
to
-102
| auto name_in_storage = Nested::extractTableName(columns[i]); | ||
| if (storage_columns.has(name_in_storage) && isObject(storage_columns.get(name_in_storage).type)) | ||
| { | ||
| have_at_least_one_physical_column = true; | ||
| continue; | ||
| } | ||
|
|
There was a problem hiding this comment.
The bug is here actually. Previously we set have_at_least_one_physical_column to true if we read the subcolumn of Object type, but it could be wrong for parts in which this subcolumn is absent. So, in case when we read only this subcolumn without any other physical columns an error accured.
CurtizJ
added
pr-bugfix
This was referenced Apr 14, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Apr 14, 2022
CurtizJ
added a commit
that referenced
this pull request
Apr 14, 2022
Backport #35687 to 22.3: Fix reading from type object
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible
Can't adjust last granuleexception while reading subcolumns of typeObject.Fixes #35407.