Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build krb5 if ENABLE_LIBRARIES is not set #35832

Merged
merged 3 commits into from Apr 4, 2022

Conversation

tonickkozlov
Copy link
Contributor

@tonickkozlov tonickkozlov commented Apr 1, 2022

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Minor improvement in contrib/krb5 build configuration.

This module has hard dependency on SSL. If ENABLE_LIBRARIES is off then SSL is disabled. With this change, building this module will not break.

This module has hard dependency on SSL. If ENABLE_LIBRARIES is off then SSL is disabled. With this change, building this module will not break.
@robot-ch-test-poll1 robot-ch-test-poll1 added the submodule changed At least one submodule changed in this PR. label Apr 1, 2022
@kssenii kssenii self-assigned this Apr 1, 2022
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Apr 1, 2022
@kssenii
Copy link
Member

kssenii commented Apr 1, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 1, 2022

update

✅ Branch has been successfully updated

@kssenii
Copy link
Member

kssenii commented Apr 3, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2022

update

✅ Branch has been successfully updated

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-build Pull request with build/testing/packaging improvement label Apr 3, 2022
@kssenii
Copy link
Member

kssenii commented Apr 4, 2022

Stateless tests (release, wide parts enabled, actions) — fail: 1 -- 02180_group_by_lowcardinality -- not related
Style Check (actions) -- not related

@kssenii kssenii merged commit 9e2f0d2 into ClickHouse:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-build Pull request with build/testing/packaging improvement submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants