Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of stat calls in storage File #36647

Merged
merged 2 commits into from Apr 30, 2022

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Apr 25, 2022

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Improve performance of reading from storage File and table functions file in case when path has globs and matched directory contains large number of files.

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Apr 25, 2022
@CurtizJ
Copy link
Member Author

CurtizJ commented Apr 25, 2022

In directory with about 25000 files:
Query: clickhouse benchmark <<< "desc file('sample/*.json', JSONAsString)" --cumulative

this PR:

localhost:9000, queries 127, QPS: 11.446, RPS: 11.446, MiB/s: 0.001, result RPS: 11.446, result MiB/s: 0.001.

0.000%          0.086 sec.
10.000%         0.086 sec.
20.000%         0.086 sec.
30.000%         0.086 sec.
40.000%         0.087 sec.
50.000%         0.087 sec.
60.000%         0.087 sec.
70.000%         0.087 sec.
80.000%         0.088 sec.
90.000%         0.089 sec.
95.000%         0.090 sec.
99.000%         0.092 sec.
99.900%         0.113 sec.
99.990%         0.113 sec.

master:

localhost:9000, queries 125, QPS: 5.699, RPS: 5.699, MiB/s: 0.000, result RPS: 5.699, result MiB/s: 0.000.

0.000%          0.173 sec.
10.000%         0.173 sec.
20.000%         0.174 sec.
30.000%         0.174 sec.
40.000%         0.174 sec.
50.000%         0.174 sec.
60.000%         0.175 sec.
70.000%         0.175 sec.
80.000%         0.176 sec.
90.000%         0.179 sec.
95.000%         0.183 sec.
99.000%         0.191 sec.
99.900%         0.204 sec.
99.990%         0.204 sec.

@alexey-milovidov alexey-milovidov self-assigned this Apr 25, 2022
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Apr 25, 2022

Thank you!

Further directions:

@alexey-milovidov
Copy link
Member

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2022

update

✅ Branch has been successfully updated

@alexey-milovidov
Copy link
Member

Stress test (debug, actions) — Found signal in gdb.log

See this: #36660

@alexey-milovidov alexey-milovidov merged commit f65267e into ClickHouse:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants