Fix optimize_aggregation_in_order with *Array aggregate functions #37046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll1
added
the
pr-bugfix
This was referenced May 9, 2022
row_begin was wrong, and before this patch aggregator processing
{row_end, row_end} range, in other words, zero range.
Fixes: ClickHouse#9113 (cc @dimarub2000)
v2: add static_cast to fix UBSan
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
azat
force-pushed
the
fix-optimize_aggregation_in_order-Array
branch
from
a375c34
to
6ada8a6
Compare
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 9, 2022
…regate functions Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com> Fixes: ClickHouse#35111 See-also: ClickHouse#37046
CurtizJ
approved these changes
May 10, 2022
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix in-order
GROUP BY(optimize_aggregation_in_order=1) with*Array(groupArrayArray/...) aggregate functionsrow_begin was wrong, and before this patch aggregator processing
{row_end, row_end} range, in other words, zero range.
Fixes: #9113 (cc @dimarub2000 @CurtizJ )