Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up WindowView WATCH #37226

Merged
merged 2 commits into from
May 16, 2022
Merged

Speed up WindowView WATCH #37226

merged 2 commits into from
May 16, 2022

Conversation

Vxider
Copy link
Contributor

@Vxider Vxider commented May 15, 2022

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

This PR improves the WATCH query in WindowView:

  1. Reduce the latency of providing query results by calling the fire_condition signal.
  2. Makes the cancel query operation(ctrl-c) faster, by checking isCancelled() more frequently.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label May 15, 2022
@kssenii kssenii self-assigned this May 15, 2022
@kssenii kssenii added the can be tested Allows running workflows for external contributors label May 15, 2022
@kssenii kssenii merged commit 128a0e1 into ClickHouse:master May 16, 2022
@Vxider Vxider deleted the wv-speedup-watch branch May 16, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels
can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vxider @kssenii @robot-clickhouse