Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check max partitions to read for each hive table #37281

Merged
merged 5 commits into from
May 18, 2022
Merged

Check max partitions to read for each hive table #37281

merged 5 commits into from
May 18, 2022

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented May 17, 2022 •
edited by kssenii
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Limit the max partitions could be queried for each hive table. Avoid resource overruns.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label May 17, 2022
@lgbo-ustc lgbo-ustc marked this pull request as ready for review May 17, 2022 07:43
@kssenii kssenii self-assigned this May 17, 2022
@kssenii kssenii added the can be tested Allows running workflows for external contributors label May 17, 2022
kssenii
kssenii approved these changes May 17, 2022
View reviewed changes
src/Storages/Hive/StorageHive.cpp Outdated Show resolved Hide resolved
@lgbo-ustc lgbo-ustc changed the title Add max partitions to query check for each hive table Check max partitions to read for each hive table May 17, 2022
@kssenii
Copy link
Member

kssenii commented May 18, 2022

ClickHouse special build check (actions) — 6/7 artifact groups are OK

/CMakeFiles/dbms.dir/Backups/BackupUtils.cpp.o -c ../src/Backups/BackupUtils.cpp
May 17 12:29:35 /build/build_docker/../src/Backups/BackupUtils.cpp:369:22: error: 'auto &' can be declared as 'const auto &' [readability-qualified-auto,-warnings-as-errors]
May 17 12:29:35                 for (auto & [relative_path, backup_entry] : info.data)
May 17 12:29:35                      ^
May 17 12:29:35                      const 
May 17 12:29:35 /build/build_docker/../src/Backups/BackupUtils.cpp:377:18: error: 'auto &' can be declared as 'const auto &' [readability-qualified-auto,-warnings-as-errors]
May 17 12:29:35             for (auto & [relative_path, backup_entry] : info.data)
May 17 12:29:35                  ^
May 17 12:29:35                  const 
May 17 12:29:35 214897 warnings generated.
May 17 12:29:35 Suppressed 215116 warnings (2

@kssenii kssenii merged commit f9b08ae into ClickHouse:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgbo-ustc @kssenii @robot-ch-test-poll