Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on joining with dictionary on some conditions #37530

Merged
merged 6 commits into from
Jun 1, 2022

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented May 25, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix error on joining with dictionary on some conditions. Close #37386

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label May 25, 2022
@Avogar Avogar self-assigned this May 25, 2022
@vdimir
Copy link
Member Author

vdimir commented May 25, 2022

PullRequestCI / FastTest (pull_request) Failing after 14m — FastTest

I'm going to check if added assert is too strict or need to fix

@vdimir vdimir force-pushed the join_cond_dict_issue_37386 branch 3 times, most recently from 1fad95c to 895fe5d Compare May 30, 2022 15:57
@vdimir vdimir marked this pull request as draft May 30, 2022 15:59
@vdimir vdimir force-pushed the join_cond_dict_issue_37386 branch from dba7ff3 to fed3812 Compare May 31, 2022 16:03
@vdimir vdimir force-pushed the join_cond_dict_issue_37386 branch from fed3812 to 284c9bc Compare May 31, 2022 17:40
@vdimir vdimir marked this pull request as ready for review June 1, 2022 10:42
@vdimir vdimir requested a review from Avogar June 1, 2022 10:42
@vdimir
Copy link
Member Author

vdimir commented Jun 1, 2022

Since we have low-cardinality conversion in appendFromBlock I've just add assert that compare block up to low-cardinality.

@vdimir vdimir merged commit c466cde into ClickHouse:master Jun 1, 2022
@vdimir vdimir deleted the join_cond_dict_issue_37386 branch June 1, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query with dictionary. Server crashes. Received signal Segmentation fault
3 participants