-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Unknown identifier (aggregate-function)
exception which appears when a user tries to calculate WINDOW ORDER BY/PARTITION BY expressions over aggregate functions
#39762
Merged
novikd
merged 5 commits into
ClickHouse:master
from
quickhouse:betterorderbyoptimization
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`ExpressionAnalyzer`, shall be `aggregated_columns`.
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jul 31, 2022
novikd
added
the
can be tested
Allows running workflows for external contributors
label
Jul 31, 2022
novikd
approved these changes
Jul 31, 2022
Enmk
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Aug 11, 2022
…tion Fixed `Unknown identifier (aggregate-function)` exception which appears when a user tries to calculate WINDOW ORDER BY/PARTITION BY expressions over aggregate functions — backport of ClickHouse#39762
@novikd What shall be next steps? |
4 tasks
Can we have backport of this to 22.8? |
Hi there, Is there any chance that this fix will be backported to 22.8? |
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 26, 2022
…n)` exception which appears when a user tries to calculate WINDOW ORDER BY/PARTITION BY expressions over aggregate functions
robot-clickhouse
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Oct 26, 2022
novikd
added a commit
that referenced
this pull request
Oct 30, 2022
Backport #39762 to 22.8: Fixed `Unknown identifier (aggregate-function)` exception which appears when a user tries to calculate WINDOW ORDER BY/PARTITION BY expressions over aggregate functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-bugfix
Pull request with bugfix, not backported by default
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed
Unknown identifier (aggregate-function)
exception which appears when a user tries to calculate WINDOW ORDER BY/PARTITION BY expressions over aggregate functions:which gives:
The bug was introduced in #34632 .