Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base58 fix handling leading 0 / '1' #40620

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Conversation

zvonand
Copy link
Contributor

@zvonand zvonand commented Aug 25, 2022

Fixes #40587, fixes #40536.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix base58Encode / base58Decode handling leading 0 / '1'

@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Aug 25, 2022
@rschu1ze rschu1ze self-assigned this Aug 25, 2022
@rschu1ze rschu1ze added the can be tested Allows running workflows for external contributors label Aug 25, 2022
@rschu1ze rschu1ze merged commit 1c8c83c into ClickHouse:master Aug 26, 2022
@zvonand zvonand deleted the zvonand-b58 branch August 28, 2022 15:15
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Jan 21, 2023
Enmk pushed a commit to Altinity/ClickHouse that referenced this pull request Feb 7, 2023
Enmk added a commit to Altinity/ClickHouse that referenced this pull request Feb 9, 2023
22.8 Backport of ClickHouse#40620: base58 leading ones/zeroes fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
3 participants