Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for Keeper system path modification #40918

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Fix check for Keeper system path modification #40918

merged 6 commits into from
Sep 9, 2022

Conversation

antonio2368
Copy link
Member

@antonio2368 antonio2368 commented Sep 2, 2022 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

keeper-fix: correctly compare paths in write requests to Keeper internal system node paths.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Sep 2, 2022
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Sep 7, 2022
yakov-olkhovskiy
yakov-olkhovskiy approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@yakov-olkhovskiy yakov-olkhovskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since keeper_system_path doesn't contain trailing slash this seems to be fine, but consider my note on matchPath function

@antonio2368 antonio2368 merged commit 8ae7fb1 into master Sep 9, 2022
@antonio2368 antonio2368 deleted the fix-keeper-system-path-check branch September 9, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakov-olkhovskiy yakov-olkhovskiy yakov-olkhovskiy approved these changes

Assignees

@yakov-olkhovskiy yakov-olkhovskiy

Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonio2368 @yakov-olkhovskiy @robot-ch-test-poll2