-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xxh3
hash function
#43411
Add xxh3
hash function
#43411
Conversation
@@ -290,3 +290,6 @@ | |||
[submodule "contrib/morton-nd"] | |||
path = contrib/morton-nd | |||
url = https://github.com/morton-nd/morton-nd | |||
[submodule "contrib/xxHash"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case - isn't it included in zstd?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is, but in the same way as lz4: zstd contains a snapshot of these files of some undetermined version in the past. I think it is better to use the actual lib
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
New hash function xxh3 added. Also performance of
xxHash32
andxxHash64
improved on arm thanks to library update.