New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated checking of SYSTEM SYNC REPLICA #45648
Merged
alesapin
merged 18 commits into
master
from
45508_Update_strategy_for_system_sync_replica
Feb 9, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8c885ff
Updated checking of SYSTEM SYNC REPLICA
SmitaRKulkarni a95609e
Updated to validate & remove each element instead of just last elemen…
SmitaRKulkarni 3996645
Updated to remove waiting ids till the removed log entry - Updated ch…
SmitaRKulkarni b22fd40
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica
SmitaRKulkarni 2bbe08c
Updated destructor to notify even when queue empty - Updated checking…
SmitaRKulkarni 9b457a5
Fixed clang-tidy build - Updated checking of SYSTEM SYNC REPLICA
SmitaRKulkarni 809354d
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica
SmitaRKulkarni 6cf2498
Fixed clang-tidy build for comparing strings and updated to notify af…
SmitaRKulkarni 123f3cf
Used unordered_set for log entries and fixed the callback function - …
SmitaRKulkarni b94f9f8
Merge branch 'master' into 45508_Update_strategy_for_system_sync_replica
alesapin f34ef86
Moved background task trigger before getting log entries to wait - Up…
SmitaRKulkarni ef29b61
Updated callback to return log entry ids - Updated checking of SYSTE…
SmitaRKulkarni 135615c
Removed unwanted check from before callback - Updated checking of SY…
SmitaRKulkarni fb76569
Removed state_mutex lock from addSubscriber - Updated checking of SY…
SmitaRKulkarni 34341dd
Updated locks and removed getLogEntryIds function - Updated checking…
SmitaRKulkarni ecea28a
Fixed style check - Updated checking of SYSTEM SYNC REPLICA
SmitaRKulkarni 8c9d994
Extended scope of state_mutex while adding subscriber - Updated chec…
SmitaRKulkarni 87ec32f
Updated to use znode_name instead of log_entry_id - Updated checking …
SmitaRKulkarni File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, of course you are right. Sometimes replica can decide to push something into own queue without log.