-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated checking of SYSTEM SYNC REPLICA #45648
Updated checking of SYSTEM SYNC REPLICA #45648
Conversation
Implementation: * Updated to wait for current last entry to be processed (after pulling shared log) instead of queue size becoming 0. * Updated Subscriber to notify both queue size and removed log_entry_id.
…t - Updated checking of SYSTEM SYNC REPLICA
…ecking of SYSTEM SYNC REPLICA
… of SYSTEM SYNC REPLICA
…ter adding subscriber if queue is already empty- Updated checking of SYSTEM SYNC REPLICA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix callback logic, in rest it's alright.
…Updated checking of SYSTEM SYNC REPLICA
…dated checking of SYSTEM SYNC REPLICA
…ing of SYSTEM SYNC REPLICA
…of SYSTEM SYNC REPLICA
@alesapin : |
@@ -544,8 +544,7 @@ void ReplicatedMergeTreeQueue::removeProcessedEntry(zkutil::ZooKeeperPtr zookeep | |||
if (!found && need_remove_from_zk) | |||
throw Exception(ErrorCodes::LOGICAL_ERROR, "Can't find {} in the memory queue. It is a bug. Entry: {}", | |||
entry->znode_name, entry->toString()); | |||
|
|||
notifySubscribers(queue_size); | |||
notifySubscribers(queue_size, entry->znode_name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, of course you are right. Sometimes replica can decide to push something into own queue without log.
Failure unrelated. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Updated checking of SYSTEM SYNC REPLICA resolves #45508
Implementation: