Updated checking of SYSTEM SYNC REPLICA #45648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation: * Updated to wait for current last entry to be processed (after pulling shared log) instead of queue size becoming 0. * Updated Subscriber to notify both queue size and removed log_entry_id.
robot-clickhouse-ci-2
added
the
pr-improvement
…t - Updated checking of SYSTEM SYNC REPLICA
…ecking of SYSTEM SYNC REPLICA
… of SYSTEM SYNC REPLICA
…ter adding subscriber if queue is already empty- Updated checking of SYSTEM SYNC REPLICA
alesapin
reviewed
Jan 31, 2023
…Updated checking of SYSTEM SYNC REPLICA
alesapin
approved these changes
Feb 6, 2023
…dated checking of SYSTEM SYNC REPLICA
…ing of SYSTEM SYNC REPLICA
…of SYSTEM SYNC REPLICA
|
@alesapin : |
alesapin
approved these changes
Feb 9, 2023
| @@ -544,8 +544,7 @@ void ReplicatedMergeTreeQueue::removeProcessedEntry(zkutil::ZooKeeperPtr zookeep | |||
| if (!found && need_remove_from_zk) | |||
| throw Exception(ErrorCodes::LOGICAL_ERROR, "Can't find {} in the memory queue. It is a bug. Entry: {}", | |||
| entry->znode_name, entry->toString()); | |||
|
|
|||
| notifySubscribers(queue_size); | |||
| notifySubscribers(queue_size, entry->znode_name); | |||
There was a problem hiding this comment.
Good, of course you are right. Sometimes replica can decide to push something into own queue without log.
|
Failure unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Updated checking of SYSTEM SYNC REPLICA resolves #45508
Implementation: