Rename "Query Result Cache" to "Query Cache" #45682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschu1ze
changed the title
robot-ch-test-poll2
added
the
pr-improvement
rschu1ze
changed the title
rschu1ze
force-pushed
the
rename-qrc-to-qc
branch
4 times, most recently
from
adbdf69
to
e54781d
Compare
rschu1ze
force-pushed
the
rename-qrc-to-qc
branch
2 times, most recently
from
1824fe5
to
669e206
Compare
rschu1ze
changed the title
rschu1ze
force-pushed
the
rename-qrc-to-qc
branch
2 times, most recently
from
170e3dd
to
5f63bb0
Compare
Reasons: - The cache will at some point store intermediate results as opposed to only query results. We should change the terminology now without having to worry about backward compat. - Equivalent caches in MySQL (1) and Starrocks (2) are called "query cache". - The new name is ca. 13.8% more catchy. (1) https://dev.mysql.com/doc/refman/5.6/en/query-cache.html (2) https://docs.starrocks.io/en-us/2.5/using_starrocks/query_cache
rschu1ze
force-pushed
the
rename-qrc-to-qc
branch
from
5f63bb0
to
325c6bd
Compare
serxa
approved these changes
Jan 31, 2023
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons:
The cache will at some point store intermediate results and not only query results. We should change the terminology now without having to worry about backward compat later.
Equivalent caches in MySQL and in Starrocks are called "query cache".
According to several academic studies, the new name is ca. 13.8% more catchy.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Renamed "query result cache" to "query cache"