Make Query Cache server-level settings reconfigurable at runtime #45758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
rschu1ze
force-pushed
the
qc-max_cache_size
branch
2 times, most recently
from
016fed6
to
9cb983d
Compare
rschu1ze
changed the title
rschu1ze
force-pushed
the
qc-max_cache_size
branch
from
9cb983d
to
540d672
Compare
rschu1ze
changed the title
rschu1ze
force-pushed
the
qc-max_cache_size
branch
from
540d672
to
5f70ac5
Compare
rschu1ze
changed the title
rschu1ze
changed the title
rschu1ze
force-pushed
the
qc-max_cache_size
branch
from
5f70ac5
to
216636f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
programs/server/Server.cpp
Outdated
Comment on lines
1521
to
1522
| global_context->setQueryCache(); | ||
| global_context->updateQueryCacheConfiguration(config()); |
There was a problem hiding this comment.
don't you think setQueryCache is loosing its meaning here? maybe make it to accept config parameter right away?
There was a problem hiding this comment.
Semantics are a bit weird, I agree, thanks. Let me make it more pretty.
yakov-olkhovskiy
approved these changes
Feb 2, 2023
rschu1ze
force-pushed
the
qc-max_cache_size
branch
from
91b8e6e
to
b1889b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ rename setting
max_entry_recordstomax_entry_rowsfor consistency with other settings.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The query cache's server-level settings are now reconfigurable at runtime