Lock zero copy parts more atomically #49211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-bugfix
…kHouse into fix_zero_copy_not_atomic
|
This is an automated comment for commit 6f3f202 with description of existing statuses. It's updated for the latest CI running
|
|
You can ask -- what does it mean "more atomically"? Because we still have places where we do it non-atomically, but all merges/mutations/fetches create zero-copy locks atomically with parts commit now. |
| @@ -861,6 +868,12 @@ class StorageReplicatedMergeTree final : public MergeTreeData | |||
| int32_t mode = zkutil::CreateMode::Persistent, bool replace_existing_lock = false, | |||
| const String & path_to_set_hardlinked_files = "", const NameSet & hardlinked_files = {}); | |||
|
|
|||
| static void getZeroCopyLockNodeCreaetOps( | |||
There was a problem hiding this comment.
typo
Suggested change
| static void getZeroCopyLockNodeCreaetOps( | |
| static void getZeroCopyLockNodeCreateOps( |
SmitaRKulkarni
approved these changes
May 2, 2023
|
Bad cast: #49445 |
|
logger issues #49420 |
|
Keeper multinode #49446 |
|
Really hard to validate this bugfix |
tavplubix
reviewed
Aug 30, 2023
| auto error = zookeeper->tryMulti(ops, responses); | ||
| if (error == Coordination::Error::ZOK) | ||
| size_t failed_op = zkutil::getFailedOpIndex(error, responses); | ||
| /// Part was locked before, unfortunately it's possible during moves |
There was a problem hiding this comment.
@alesapin, did you mean replace/move partition or moves between disks? AFAIU, during replace/move partition, the existing lock is ephemeral...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible dataloss because of non-atomic locking in zero copy replication. Fixes #48474 (comment).