New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some bad error messages #49420
Fix some bad error messages #49420
Conversation
This is an automated comment for commit 495325f with description of existing statuses. It's updated for the latest CI running
|
@@ -150,7 +150,7 @@ namespace | |||
if (text == "bc") | |||
throw Exception(ErrorCodes::CANNOT_PARSE_DATETIME, "Era BC exceeds the range of DateTime"); | |||
else if (text != "ad") | |||
throw Exception(ErrorCodes::CANNOT_PARSE_DATETIME, "Unknown era {}", text); | |||
throw Exception(ErrorCodes::CANNOT_PARSE_DATETIME, "Unknown era {} (expected 'ad' or 'bc')", text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "expected 'ad' only"?
bc is not allowed as per the line above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, technically bc
is expected too :) Yes, it's not supported, but it's a valid value
Changelog category (leave one):
Fixes #49408