New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AsynchronousReadIndirectBufferFromRemoteFS breaking on short seeks #49525
Conversation
This is an automated comment for commit 85494b2 with description of existing statuses. It's updated for the latest CI running
|
It looks like some files related to the tests are not committed. |
Removed |
off_t res = static_cast<off_t>(file_offset_of_buffer_end - available() + bytes_to_ignore); | ||
return res; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
off_t res = static_cast<off_t>(file_offset_of_buffer_end - available() + bytes_to_ignore); | |
return res; | |
return file_offset_of_buffer_end - available() + bytes_to_ignore; |
1066e83
to
7c085ec
Compare
Remaining failed tests seem unrelated:
|
…FS breaking on short seeks
…FS breaking on short seeks
…FS breaking on short seeks
Whoops, no, it's only needed on 23.4, cancelling all those other cherry picks. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed error "Attempt to read after eof" when reading parquet files from S3 of size between ~1 MB and ~2 MB. On earlier versions, use setting
remote_filesystem_read_method='read'
as a workaround.bytes_to_ignore
wasn't used in some of the places where it should be used, e.g.getPosition()
.