New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improve HDFS ReadBuffer for read end of file #50063
Merged
kssenii
merged 12 commits into
ClickHouse:master
from
KevinyhZou:minor_improve_hdfs_read_buffer
Aug 3, 2023
Merged
Minor improve HDFS ReadBuffer for read end of file #50063
kssenii
merged 12 commits into
ClickHouse:master
from
KevinyhZou:minor_improve_hdfs_read_buffer
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kssenii
added
the
can be tested
Allows running workflows for external contributors
label
May 22, 2023
robot-clickhouse
added
the
pr-improvement
Pull request with some product improvements
label
May 22, 2023
This is an automated comment for commit 73ac1bf with description of existing statuses. It's updated for the latest CI running
|
kssenii
reviewed
May 22, 2023
kssenii
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-improvement
Pull request with some product improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
While read small files from hdfs by gluten, we found that it will cost more times when compare to directly query by spark.
In my testcases, the table contains 3 rows data, when query
select * from $table
by use HDFSReadBuffer, it will cost 1.5 seconds to read, as by spark this cost is 0.2 second.And we found the time is cost mostly while read the file end: it will check the read cursor whether beyond the file length in libhdfs3, and get file length will take the mostly cost. So we make a improvment:get and keep the file length in a variable at the construction function, and so avoid to get file length to compare every time.
And by use this, the time cost is equals to spark in such query above.
Documentation entry for user-facing changes