Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improve HDFS ReadBuffer for read end of file #50063

Merged
merged 12 commits into from Aug 3, 2023
Merged

Minor improve HDFS ReadBuffer for read end of file #50063

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e6d6d41
minor improve read buffer of hdfs
KevinyhZou May 22, 2023
15b847b
init file_size as 0
KevinyhZou May 24, 2023
349083e
Update ReadBufferFromHDFS.cpp
kssenii Jun 30, 2023
a8e2eb9
Merge branch 'master' into minor_improve_hdfs_read_buffer
kssenii Jul 1, 2023
6ea96f0
Merge branch 'master' into minor_improve_hdfs_read_buffer
kssenii Jul 22, 2023
30b6cf0
Merge branch 'master' into minor_improve_hdfs_read_buffer
kssenii Jul 30, 2023
dd85c3c
Update ReadBufferFromHDFS.cpp
kssenii Jul 30, 2023
74c0574
Update ReadBufferFromHDFS.cpp
kssenii Jul 31, 2023
5880a0a
Update ReadBufferFromHDFS.cpp
kssenii Aug 1, 2023
ccf9fa9
Update ReadBufferFromHDFS.cpp
kssenii Aug 1, 2023
8180474
Merge branch 'master' into minor_improve_hdfs_read_buffer
kssenii Aug 2, 2023
73ac1bf
Merge branch 'master' into minor_improve_hdfs_read_buffer
kssenii Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Storages/HDFS/ReadBufferFromHDFS.cpp
View file
Open in desktop
Expand Up @@ -41,6 +41,7 @@ struct ReadBufferFromHDFS::ReadBufferFromHDFSImpl : public BufferWithOwnMemory<S

off_t file_offset = 0;
off_t read_until_position = 0;
off_t file_size;

explicit ReadBufferFromHDFSImpl(
const std::string & hdfs_uri_,
Expand All @@ -63,6 +64,7 @@ struct ReadBufferFromHDFS::ReadBufferFromHDFSImpl : public BufferWithOwnMemory<S
throw Exception(ErrorCodes::CANNOT_OPEN_FILE,
"Unable to open HDFS file: {}. Error: {}",
hdfs_uri + hdfs_file_path, std::string(hdfsGetLastError()));
file_size = getFileSize();
kssenii marked this conversation as resolved.
Show resolved Hide resolved
}

~ReadBufferFromHDFSImpl() override
Expand Down Expand Up @@ -95,6 +97,10 @@ struct ReadBufferFromHDFS::ReadBufferFromHDFSImpl : public BufferWithOwnMemory<S
{
num_bytes_to_read = internal_buffer.size();
}
if (file_size != 0 && file_offset >= file_size)
{
return false;
}

ResourceGuard rlock(read_settings.resource_link, num_bytes_to_read);
int bytes_read;
Expand Down