New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSan support for Rust #50541
MSan support for Rust #50541
Conversation
This is an automated comment for commit bf127f4 with description of existing statuses. It's updated for the latest CI running
|
Previously you have to unpoison memory from the Rust, however Rust does supports MSan, so let's simply use it. But for this we need nightly Rust and recompile standard library. Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
This is a wrong idea in the first place. Let's rollback. |
@alexey-milovidov can you elaborate? |
When it updates, literally nightly, the libraries stop building. There are external Rust enthusiasts like you, though... |
But it's ok if we will fixate the version somehow. |
The problem is that it's updated even in release branches, e.g. in 23.5 now the build is completely broken, unfortunately, see the report |
We can install a specific nightly instead of just nightly:
OTOH, I don't know anything about the rust project. I don't know if these builds are completely static and if they are for how long they keep them. |
at least it works yet. I think we're safe with pin |
Yes, this is OK as a temporary solution (since nightly archives stored for a long time, i.e. there is an archive for 2015 - https://static.rust-lang.org/dist/2015-01-01/) But in a long term #49601 should be done. |
Because of using Rust nightly, and without ClickHouse#49601 the Rust toolchain is very unstable, and can be frequently failed. So let's ping particular version. Also I've looked and it seems that Rust archives stores this archive without any TTL, since there is even a version for 2015 year. Follow-up for: ClickHouse#50541 Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Previously you have to unpoison memory from the Rust, however Rust does supports MSan, so let's simply use it.
But for this we need nightly Rust and recompile standard library.
Changelog category (leave one):
Fixes: #50525 (cc @al13n321 )
Supersedes: #50539 (cc @alexey-milovidov )