Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSan support for Rust #50541

Merged
merged 1 commit into from Jun 5, 2023
Merged

MSan support for Rust #50541

merged 1 commit into from Jun 5, 2023

Conversation

azat
Copy link
Collaborator

@azat azat commented Jun 4, 2023

Previously you have to unpoison memory from the Rust, however Rust does supports MSan, so let's simply use it.

But for this we need nightly Rust and recompile standard library.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #50525 (cc @al13n321 )
Supersedes: #50539 (cc @alexey-milovidov )

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 4, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Jun 4, 2023

This is an automated comment for commit bf127f4 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

Previously you have to unpoison memory from the Rust, however Rust does
supports MSan, so let's simply use it.

But for this we need nightly Rust and recompile standard library.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@alexey-milovidov alexey-milovidov merged commit 5048f24 into ClickHouse:master Jun 5, 2023
249 of 257 checks passed
@azat azat deleted the rust-msan branch June 5, 2023 06:49
@alexey-milovidov
Copy link
Member

This is a wrong idea in the first place. Let's rollback.

@azat
Copy link
Collaborator Author

azat commented Jul 4, 2023

@alexey-milovidov can you elaborate?

@alexey-milovidov
Copy link
Member

When it updates, literally nightly, the libraries stop building.
And we have just 1 person on the team with some experience in Rust.

There are external Rust enthusiasts like you, though...

@alexey-milovidov
Copy link
Member

But it's ok if we will fixate the version somehow.

@Felixoid
Copy link
Member

Felixoid commented Jul 6, 2023

The problem is that it's updated even in release branches, e.g. in 23.5 now the build is completely broken, unfortunately, see the report

@Algunenano
Copy link
Member

We can install a specific nightly instead of just nightly:

$ rustup toolchain install nightly-2023-07-04

OTOH, I don't know anything about the rust project. I don't know if these builds are completely static and if they are for how long they keep them.

@Felixoid
Copy link
Member

Felixoid commented Jul 6, 2023

rustup install nightly-2022-02-02

at least it works yet. I think we're safe with pin nightly-2023-07-04 for a while.

@azat
Copy link
Collaborator Author

azat commented Jul 6, 2023

Yes, this is OK as a temporary solution (since nightly archives stored for a long time, i.e. there is an archive for 2015 - https://static.rust-lang.org/dist/2015-01-01/)

But in a long term #49601 should be done.

azat added a commit to azat/ClickHouse that referenced this pull request Jul 6, 2023
Because of using Rust nightly, and without ClickHouse#49601 the Rust toolchain is
very unstable, and can be frequently failed.

So let's ping particular version.

Also I've looked and it seems that Rust archives stores this archive
without any TTL, since there is even a version for 2015 year.

Follow-up for: ClickHouse#50541
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSAN error in Rust 'skim' library when pressing ctrl-r in clickhouse client
5 participants