Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo update to fix build with nightly #51721

Merged
merged 2 commits into from Jul 4, 2023

Conversation

Algunenano
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Update cargo dependencies

Documentation entry for user-facing changes

Closes #51699

Since #50541 rust nightly is necessary, but building with a recent nightly is impossible because of old dependencies. Just update them.

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-build Pull request with build/testing/packaging improvement label Jul 3, 2023
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Jul 3, 2023

This is an automated comment for commit cdc0fd1 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

@alexey-milovidov alexey-milovidov self-assigned this Jul 3, 2023
@Algunenano
Copy link
Member Author

Test failures:

  • Stress test (ubsan) -> OOM. It's odd because I don't see the server doing anything when it was killed. Not related to the changes.

@nikitamikhaylov
Copy link
Member

Stress test (ubsan) — OOM in dmesg - what should I fix?

@nikitamikhaylov nikitamikhaylov merged commit 3d5acdc into ClickHouse:master Jul 4, 2023
6 of 8 checks passed
@alexey-milovidov
Copy link
Member

@Algunenano, can we also pin Rust to whatever snapshot, git hash, etc... that works today, instead of "nightly"?

@Algunenano
Copy link
Member Author

In theory it should be possible with something like:

$ cat rust/skim/rust-toolchain.toml
[toolchain]
channel = "nightly-2024-07-04"

This is how the documentation says should work, but it doesn't. It didn't complain about me not having it installed and if I set it to a wrong date in the future it doesn't complain either. Maybe it has something to do with how corrosion picks up things.

Maybe we could document it without actually enforcing it.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 6, 2023
Felixoid added a commit that referenced this pull request Jul 6, 2023
Backport #51721 to 23.6: Run cargo update to fix build with nightly
Felixoid added a commit that referenced this pull request Jul 6, 2023
Backport #51721 to 23.5: Run cargo update to fix build with nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-build Pull request with build/testing/packaging improvement pr-must-backport-cloud v23.5-must-backport v23.6-must-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build errors from rust
7 participants